Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old Findings Report #3560

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

madelondohmen
Copy link
Contributor

@madelondohmen madelondohmen commented Sep 19, 2024

Changes

This PR fixes the old "Download PDF" button on the Findings page, which redirected to the old OOI Report.
This report doesn't exist anymore in the new flow.

What this PR does:

  • Change the button's name to "Generate Findings Report"
  • Redirect the button to the Export Page of the new report flow (with all OOI's and Findings Report selected)
  • Remove ooi_report.py, ooi_report.html and ooi_report_404.html
  • Remove the corresponding URLs
  • Remove the corresponding tests
  • Remove mock from conftest.py
  • Add "Source" to new Findings Report

Issue link

Closes #3500

Demo

Opname.2024-09-19.095517.mp4

QA notes

  • Go to Findings page
  • Click "Generate Findings Report"
  • Check if...
    • ...you were redirected to the Export Page
    • ...all OOI's are selected
    • ...only the Findings Report is selected
  • Generate the report

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made. // Removed redundant unit tests
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@madelondohmen madelondohmen self-assigned this Sep 19, 2024
@madelondohmen madelondohmen requested a review from a team as a code owner September 19, 2024 07:57
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@stephanie0x00
Copy link
Contributor

QA notes:

The current selection of selected items is a bit too broad, as this also includes actual findings (eg. jQuery versions). This should be reduced to hosts only.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong encoding links to background info in report leads to 404-pages
3 participants