Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cohttp-lwt: Preserve extended signature of IO in Server.S. #1013

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

mefyl
Copy link
Contributor

@mefyl mefyl commented Jan 5, 2024

Fixes #1010

@mseri
Copy link
Collaborator

mseri commented Jan 5, 2024

Oh thank you very much!

@mseri mseri merged commit 4a9361e into mirage:master Jan 5, 2024
18 of 19 checks passed
mseri added a commit to mseri/opam-repository that referenced this pull request Jan 5, 2024
CHANGES:

- cohttp-eio: Don't blow up Server on client disconnections. (mefyl mirage/ocaml-cohttp#1011)
- cohttp-eio: Match body encoding with headers. (mefyl mirage/ocaml-cohttp#1012)
- cohttp-lwt: Preserve extended `Server.S.IO` signature. (mefyl mirage/ocaml-cohttp#1013)
mseri added a commit to mseri/opam-repository that referenced this pull request Jan 5, 2024
CHANGES:

- cohttp-eio: Don't blow up Server on client disconnections. (mefyl mirage/ocaml-cohttp#1011)
- cohttp-eio: Match body encoding with headers. (mefyl mirage/ocaml-cohttp#1012)
- cohttp-lwt: Preserve extended `Server.S.IO` signature. (mefyl mirage/ocaml-cohttp#1013)
nberth pushed a commit to nberth/opam-repository that referenced this pull request Jun 18, 2024
CHANGES:

- cohttp-eio: Don't blow up Server on client disconnections. (mefyl mirage/ocaml-cohttp#1011)
- cohttp-eio: Match body encoding with headers. (mefyl mirage/ocaml-cohttp#1012)
- cohttp-lwt: Preserve extended `Server.S.IO` signature. (mefyl mirage/ocaml-cohttp#1013)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with cohttp-lwt Server module IO
2 participants