Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cohttp-eio: generate Date header in Server #955

Merged
merged 3 commits into from
Dec 21, 2022
Merged

Conversation

bikallem
Copy link
Contributor

@bikallem bikallem commented Dec 19, 2022

Generates Date header in responses from Cohttp_eio.Server.

Fixes #932

/cc @mseri @talex5

@bikallem bikallem force-pushed the date-header branch 2 times, most recently from fdd1cfc to 27d176f Compare December 19, 2022 12:26
cohttp-eio/src/server.ml Outdated Show resolved Hide resolved
@bikallem
Copy link
Contributor Author

@mseri I have addressed all of your feedback.

@mseri mseri merged commit 09fcce2 into mirage:master Dec 21, 2022
mseri added a commit to mseri/opam-repository that referenced this pull request Apr 28, 2023
…p-curl, cohttp-eio, cohttp-lwt-jsoo, cohttp-lwt-unix, cohttp-lwt, cohttp-mirage, cohttp-server-lwt-unix, cohttp-top, cohttp and http (6.0.0~alpha1)

CHANGES:

- cohttp,cohttp-async server: correctly close broken streams (reported by Stéphane Glondu, fix by samhot and anuragsoni)
- cohttp-eio: remove unused code from tests to work with Eio 0.8 (talex5 mirage/ocaml-cohttp#967)
- Upgrade dune to v3.0 (bikallem mirage/ocaml-cohttp#947)
- cohttp-eio: allow client to optionally configure request pipelining (bikallem mirage/ocaml-cohttp#949)
- cohttp-eio: update to Eio 0.7 (talex5 mirage/ocaml-cohttp#952)
- cohttp-eio: update examples to use eio 0.7 primitives (bikallem mirage/ocaml-cohttp#957)
- cohttp-eio: generate Date header in responses (bikallem mirage/ocaml-cohttp#955)
- cohttp-eio: further improve Cohttp_eio.Client ergonomics (bikallem #?)
- cohttp-eio: server api improvements (bikallem mirage/ocaml-cohttp#962)
toots pushed a commit to savonet/opam-repository that referenced this pull request May 10, 2023
…p-curl, cohttp-eio, cohttp-lwt-jsoo, cohttp-lwt-unix, cohttp-lwt, cohttp-mirage, cohttp-server-lwt-unix, cohttp-top, cohttp and http (6.0.0~alpha1)

CHANGES:

- cohttp,cohttp-async server: correctly close broken streams (reported by Stéphane Glondu, fix by samhot and anuragsoni)
- cohttp-eio: remove unused code from tests to work with Eio 0.8 (talex5 mirage/ocaml-cohttp#967)
- Upgrade dune to v3.0 (bikallem mirage/ocaml-cohttp#947)
- cohttp-eio: allow client to optionally configure request pipelining (bikallem mirage/ocaml-cohttp#949)
- cohttp-eio: update to Eio 0.7 (talex5 mirage/ocaml-cohttp#952)
- cohttp-eio: update examples to use eio 0.7 primitives (bikallem mirage/ocaml-cohttp#957)
- cohttp-eio: generate Date header in responses (bikallem mirage/ocaml-cohttp#955)
- cohttp-eio: further improve Cohttp_eio.Client ergonomics (bikallem #?)
- cohttp-eio: server api improvements (bikallem mirage/ocaml-cohttp#962)
toots pushed a commit to savonet/opam-repository that referenced this pull request May 11, 2023
…p-curl, cohttp-eio, cohttp-lwt-jsoo, cohttp-lwt-unix, cohttp-lwt, cohttp-mirage, cohttp-server-lwt-unix, cohttp-top, cohttp and http (6.0.0~alpha1)

CHANGES:

- cohttp,cohttp-async server: correctly close broken streams (reported by Stéphane Glondu, fix by samhot and anuragsoni)
- cohttp-eio: remove unused code from tests to work with Eio 0.8 (talex5 mirage/ocaml-cohttp#967)
- Upgrade dune to v3.0 (bikallem mirage/ocaml-cohttp#947)
- cohttp-eio: allow client to optionally configure request pipelining (bikallem mirage/ocaml-cohttp#949)
- cohttp-eio: update to Eio 0.7 (talex5 mirage/ocaml-cohttp#952)
- cohttp-eio: update examples to use eio 0.7 primitives (bikallem mirage/ocaml-cohttp#957)
- cohttp-eio: generate Date header in responses (bikallem mirage/ocaml-cohttp#955)
- cohttp-eio: further improve Cohttp_eio.Client ergonomics (bikallem #?)
- cohttp-eio: server api improvements (bikallem mirage/ocaml-cohttp#962)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cohttp-eio(server) : an origin server must generate Date header
2 participants