-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cohttp-eio: generate Date header in Server #955
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bikallem
force-pushed
the
date-header
branch
2 times, most recently
from
December 19, 2022 12:26
fdd1cfc
to
27d176f
Compare
mseri
reviewed
Dec 19, 2022
mseri
reviewed
Dec 19, 2022
mseri
reviewed
Dec 19, 2022
…rror responses for performance reasons
bikallem
force-pushed
the
date-header
branch
from
December 20, 2022 10:30
08ac953
to
3819867
Compare
@mseri I have addressed all of your feedback. |
mseri
added a commit
to mseri/opam-repository
that referenced
this pull request
Apr 28, 2023
…p-curl, cohttp-eio, cohttp-lwt-jsoo, cohttp-lwt-unix, cohttp-lwt, cohttp-mirage, cohttp-server-lwt-unix, cohttp-top, cohttp and http (6.0.0~alpha1) CHANGES: - cohttp,cohttp-async server: correctly close broken streams (reported by Stéphane Glondu, fix by samhot and anuragsoni) - cohttp-eio: remove unused code from tests to work with Eio 0.8 (talex5 mirage/ocaml-cohttp#967) - Upgrade dune to v3.0 (bikallem mirage/ocaml-cohttp#947) - cohttp-eio: allow client to optionally configure request pipelining (bikallem mirage/ocaml-cohttp#949) - cohttp-eio: update to Eio 0.7 (talex5 mirage/ocaml-cohttp#952) - cohttp-eio: update examples to use eio 0.7 primitives (bikallem mirage/ocaml-cohttp#957) - cohttp-eio: generate Date header in responses (bikallem mirage/ocaml-cohttp#955) - cohttp-eio: further improve Cohttp_eio.Client ergonomics (bikallem #?) - cohttp-eio: server api improvements (bikallem mirage/ocaml-cohttp#962)
toots
pushed a commit
to savonet/opam-repository
that referenced
this pull request
May 10, 2023
…p-curl, cohttp-eio, cohttp-lwt-jsoo, cohttp-lwt-unix, cohttp-lwt, cohttp-mirage, cohttp-server-lwt-unix, cohttp-top, cohttp and http (6.0.0~alpha1) CHANGES: - cohttp,cohttp-async server: correctly close broken streams (reported by Stéphane Glondu, fix by samhot and anuragsoni) - cohttp-eio: remove unused code from tests to work with Eio 0.8 (talex5 mirage/ocaml-cohttp#967) - Upgrade dune to v3.0 (bikallem mirage/ocaml-cohttp#947) - cohttp-eio: allow client to optionally configure request pipelining (bikallem mirage/ocaml-cohttp#949) - cohttp-eio: update to Eio 0.7 (talex5 mirage/ocaml-cohttp#952) - cohttp-eio: update examples to use eio 0.7 primitives (bikallem mirage/ocaml-cohttp#957) - cohttp-eio: generate Date header in responses (bikallem mirage/ocaml-cohttp#955) - cohttp-eio: further improve Cohttp_eio.Client ergonomics (bikallem #?) - cohttp-eio: server api improvements (bikallem mirage/ocaml-cohttp#962)
toots
pushed a commit
to savonet/opam-repository
that referenced
this pull request
May 11, 2023
…p-curl, cohttp-eio, cohttp-lwt-jsoo, cohttp-lwt-unix, cohttp-lwt, cohttp-mirage, cohttp-server-lwt-unix, cohttp-top, cohttp and http (6.0.0~alpha1) CHANGES: - cohttp,cohttp-async server: correctly close broken streams (reported by Stéphane Glondu, fix by samhot and anuragsoni) - cohttp-eio: remove unused code from tests to work with Eio 0.8 (talex5 mirage/ocaml-cohttp#967) - Upgrade dune to v3.0 (bikallem mirage/ocaml-cohttp#947) - cohttp-eio: allow client to optionally configure request pipelining (bikallem mirage/ocaml-cohttp#949) - cohttp-eio: update to Eio 0.7 (talex5 mirage/ocaml-cohttp#952) - cohttp-eio: update examples to use eio 0.7 primitives (bikallem mirage/ocaml-cohttp#957) - cohttp-eio: generate Date header in responses (bikallem mirage/ocaml-cohttp#955) - cohttp-eio: further improve Cohttp_eio.Client ergonomics (bikallem #?) - cohttp-eio: server api improvements (bikallem mirage/ocaml-cohttp#962)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generates Date header in responses from
Cohttp_eio.Server
.Fixes #932
/cc @mseri @talex5