deprecated samples_per_pass parameter, removed oldpath.cpp

mitsuba-renderer · Nov 23, 2022 · 8ba8528 · 8ba8528
1 parent 47a3958
commit 8ba8528
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 177 deletions.
diff --git a/src/integrators/CMakeLists.txt b/src/integrators/CMakeLists.txt
@@ -5,7 +5,6 @@ add_plugin(depth      depth.cpp)
 add_plugin(direct     direct.cpp)
 add_plugin(moment     moment.cpp)
 add_plugin(path       path.cpp)
-add_plugin(oldpath    oldpath.cpp)
 add_plugin(ptracer    ptracer.cpp)
 add_plugin(stokes     stokes.cpp)
 add_plugin(volpath    volpath.cpp)

diff --git a/src/integrators/oldpath.cpp b/src/integrators/oldpath.cpp
diff --git a/src/render/integrator.cpp b/src/render/integrator.cpp
@@ -65,6 +65,12 @@ MI_VARIANT SamplingIntegrator<Float, Spectrum>::SamplingIntegrator(const Propert
     }
 
     m_samples_per_pass = props.get<uint32_t>("samples_per_pass", (uint32_t) -1);
+    if (m_samples_per_pass != (uint32_t) -1) {
+        Log(Warn, "The 'samples_per_pass' is deprecated, as a poor choice of "
+                  "this parameter can have a detrimental effect on performance. "
+                  "Please leave it undefined; Mitsuba will then automatically "
+                  "choose the necessary number of passes.");
+    }
 }
 
 MI_VARIANT SamplingIntegrator<Float, Spectrum>::~SamplingIntegrator() { }