Skip to content

Commit

Permalink
Expose principal point in Sensor traverse mechanism
Browse files Browse the repository at this point in the history
  • Loading branch information
Jérémy Riviere authored and njroussel committed Nov 27, 2023
1 parent 7b3449c commit f59faa5
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions src/sensors/perspective.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ Perspective pinhole camera (:monosp:`perspective`)
* - principal_point_offset_x, principal_point_offset_y
- |float|
- Specifies the position of the camera's principal point relative to the center of the film.
- |exposed|, |differentiable|, |discontinuous|

* - srf
- |spectrum|
Expand Down Expand Up @@ -153,8 +154,10 @@ class PerspectiveCamera final : public ProjectiveCamera<Float, Spectrum> {

void traverse(TraversalCallback *callback) override {
Base::traverse(callback);
callback->put_parameter("x_fov", m_x_fov, ParamFlags::Differentiable | ParamFlags::Discontinuous);
callback->put_parameter("to_world", *m_to_world.ptr(), ParamFlags::Differentiable | ParamFlags::Discontinuous);
callback->put_parameter("x_fov", m_x_fov, ParamFlags::Differentiable | ParamFlags::Discontinuous);
callback->put_parameter("principal_point_offset_x", m_principal_point_offset.x(), ParamFlags::Differentiable | ParamFlags::Discontinuous);
callback->put_parameter("principal_point_offset_y", m_principal_point_offset.y(), ParamFlags::Differentiable | ParamFlags::Discontinuous);
callback->put_parameter("to_world", *m_to_world.ptr(), ParamFlags::Differentiable | ParamFlags::Discontinuous);
}

void parameters_changed(const std::vector<std::string> &keys) override {
Expand Down

0 comments on commit f59faa5

Please sign in to comment.