Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rayloader and dummy_sensor with example #981

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SimonLi12342
Copy link

@SimonLi12342 SimonLi12342 commented Nov 19, 2023

Ray Loader

Description

dummy_sensor in root folder, Rayloader in src/python/python/loaders.

TODO:

some TODO's added in the Rayloder for different film sizes of sensors

Testing

root folder: volumetric_dumn_test.ipynb

Checklist

  • My code follows the style guidelines of this project
  • My changes generate no new warnings
  • My code also compiles for cuda_* and llvm_* variants. If you can't test this, please leave below
  • I have commented my code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I cleaned the commit history and removed any "Merge" commits
  • I give permission that the Mitsuba 3 project may redistribute my contributions under the terms of its license

@merlinND
Copy link
Member

Hello @SimonLi12342,

Was this pull request opened by accident?

@SimonLi12342
Copy link
Author

SimonLi12342 commented Nov 20, 2023

Hello,

This pull request was not opened by accident. It is intended to be a new approach similar to BatchSensor. I am not sure why the TeamCity build failed.

@njroussel
Copy link
Member

Hi @merlinND

This is a semester project 😄

@SimonLi12342 Thank you, I'll have a look at it this week 👍

@SimonLi12342
Copy link
Author

Hello @merlinND and @njroussel,

Thank you for the comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants