Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark require-full-match as experimental #497

Merged
merged 4 commits into from
Jul 7, 2024

Commits on May 29, 2024

  1. Mark require-full-match as experimental

    I did some more testing. There are some corner-cases where it doesn't work; for example if `info` is used it fails, because our serializer / deserializer isn't lossless.
    
    For example; from the insta tests, One is `Map`; the other a `Struct`:
    
    ```
    [insta/src/snapshot.rs:440:20] self.metadata.trim_for_persistence() = MetaData {
        source: None,
        assertion_line: None,
        description: Some(
            "The snapshot is four integers",
        ),
        expression: None,
        info: Some(
            Map(
                [
                    (
                        String(
                            "env",
                        ),
                        Map(
                            [
                                (
                                    String(
                                        "ENVIRONMENT",
                                    ),
                                    String(
                                        "production",
                                    ),
                                ),
                            ],
                        ),
                    ),
                    (
                        String(
                            "cmdline",
                        ),
                        Seq(
                            [
                                String(
                                    "my-tool",
                                ),
                                String(
                                    "run",
                                ),
                            ],
                        ),
                    ),
                ],
            ),
        ),
        input_file: None,
    }
    [insta/src/snapshot.rs:441:24] other.metadata.trim_for_persistence() = MetaData {
        source: None,
        assertion_line: None,
        description: Some(
            "The snapshot is four integers",
        ),
        expression: None,
        info: Some(
            Struct(
                "Info",
                [
                    (
                        "env",
                        Map(
                            [
                                (
                                    String(
                                        "ENVIRONMENT",
                                    ),
                                    String(
                                        "production",
                                    ),
                                ),
                            ],
                        ),
                    ),
                    (
                        "cmdline",
                        Seq(
                            [
                                String(
                                    "my-tool",
                                ),
                                String(
                                    "run",
                                ),
                            ],
                        ),
                    ),
                ],
            ),
        ),
        input_file: None,
    }
    ```
    max-sixty committed May 29, 2024
    Configuration menu
    Copy the full SHA
    a213efc View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2024

  1. Configuration menu
    Copy the full SHA
    79a5453 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    94ff751 View commit details
    Browse the repository at this point in the history
  3. No commit message

    max-sixty committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    fceae5e View commit details
    Browse the repository at this point in the history