Upgrade structopt to clap
#518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm in favor. I already wanted to do this but I was just too lazy to pull through :) |
Still need to finish this off, one test fails. `structopt` was build on clap 2, and then its features were integrated into clap 3. So it's not actually a heavier dependency. May have to check on MSRV issues. Once we merge this, we only have one version of `syn`, which reduces our dependency size significantly.
max-sixty
commented
Jul 4, 2024
| precise-builds = true | ||
| targets = ["aarch64-apple-darwin", "x86_64-apple-darwin", "x86_64-unknown-linux-gnu", "x86_64-unknown-linux-musl", "x86_64-pc-windows-msvc"] |
There was a problem hiding this comment.
Bleh this was some autoformatting; can revert if annoying
max-sixty
added a commit
to max-sixty/insta
that referenced
this pull request
Jul 5, 2024
max-sixty
added a commit
to max-sixty/insta
that referenced
this pull request
Jul 5, 2024
max-sixty
added a commit
to max-sixty/insta
that referenced
this pull request
Jul 5, 2024
Need to upgrade structopt and then we'll reduce the compile time.
|
Can you have a look at the changes to the CI matrix here? |
|
OK, that should be fixed! |
max-sixty
commented
Aug 1, 2024
| @@ -11,21 +11,24 @@ keywords = ["snapshot", "testing", "jest"] | |||
| categories = ["development-tools::cargo-plugins"] | |||
| edition = "2018" | |||
| readme = "README.md" | |||
| rust-version = "1.61.0" | |||
| rust-version = "1.64.0" | |||
There was a problem hiding this comment.
Note this bumps cargo-insta to 1.64, which was released ~2 years ago, Sep 2022
insta remains on 1.60.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to finish this off, one test fails.structoptwas build on clap 2, and then its features were integrated into clap 3 — ref TeXitoi/structopt#525. So it's not actually a heavier dependency. May have to check on MSRV issues.Once we merge this, we only have one version of
syn, which reduces our dependency size significantly.This is ready for any feedback / testing. Will need to adjust the dependency spec if this gets in before we increase the
cargo-instamsrv to 1.64...cargo.lock, usecargo-msrvto verify MSRV #524 for CI to pass, at least without manually pinning dependencies