Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build to support macOS arm64/x86_64 #82

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Update build to support macOS arm64/x86_64 #82

merged 3 commits into from
Apr 22, 2024

Conversation

tom-gangemi
Copy link
Contributor

@tom-gangemi tom-gangemi commented Apr 20, 2024

For issue #80. This is my first attempt at using cibuildwheel or github actions so forgive me if it has issues.
The main change is using os [macos-13, macos-14] to build the x86_64 and arm64 wheels on their respective systems.

Note that I had to remove cp37 for it to build and test successfully but there is probably a way to fix that.

@tom-gangemi
Copy link
Contributor Author

Updated to fix failing tests due to actions/setup-python#696

@miute
Copy link
Owner

miute commented Apr 22, 2024

It's working as expected.
Thank you for fixing the problem.

@miute miute merged commit c465065 into miute:main Apr 22, 2024
19 checks passed
miute pushed a commit that referenced this pull request Apr 24, 2024
* Update build to support macOS arm64/x86_64

* Tests to skip python 3.8, 3.9 for macos-14 runner

* Add newline to end of build.yml
miute pushed a commit that referenced this pull request Apr 24, 2024
* Update build to support macOS arm64/x86_64

* Tests to skip python 3.8, 3.9 for macos-14 runner

* Add newline to end of build.yml
miute pushed a commit that referenced this pull request Apr 24, 2024
* Update build to support macOS arm64/x86_64

* Tests to skip python 3.8, 3.9 for macos-14 runner

* Add newline to end of build.yml
miute added a commit that referenced this pull request Apr 24, 2024
miute added a commit that referenced this pull request Apr 24, 2024
miute pushed a commit that referenced this pull request Apr 24, 2024
* Update build to support macOS arm64/x86_64

* Tests to skip python 3.8, 3.9 for macos-14 runner

* Add newline to end of build.yml
@miute
Copy link
Owner

miute commented Apr 24, 2024

"Co-authored-by" was removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants