Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich text tables in description and comments renders as plain-text code #92

Open
trincasidra opened this issue Dec 18, 2023 · 4 comments

Comments

@trincasidra
Copy link

Desktop:

  • OS: ArchLinux (6.6.7-arch1-1)
  • Terminal: kitty (0.31.0)
  • Shell: bash (5.2.21)
  • Architecture: x86_64
  • Fjira version: 1.1.1

Describe the bug
Tables in rich text description and comments show the underlying table code as plain-text.

To Reproduce
Steps to reproduce the behavior:

  1. Create a jira issue, adding a table to its description.
  2. View this issue in fjira.
  3. Optionally, add a comment to the issue adding a table, and view that as well.

Expected behavior
The table shows and is readable in a format similar to this.

Additional notes
Issue in jira:
2023-12-18_13-49
Issue in fjira:
2023-12-18_13-51

@mk-5
Copy link
Owner

mk-5 commented Dec 18, 2023

I think it's somehow relates to #55

I will take this up soon - the problem is not that trival .. because tcell doesn't support any kind of markdown formatting.

@trincasidra
Copy link
Author

Glad to hear! I'm not entirely sure it's the same issue, as the tables have this weird adf json-like structure. I'd definitely agree with the old table format that used the | characters.

But in all honesty, I don't really know how tcell works so I may be shooting in the dark.

@mk-5
Copy link
Owner

mk-5 commented Dec 23, 2023

@trincasidra it's plus-minus about parsing markdown, and render it in tcell. So I need to do some selection - which markdown tags will be supported from the beginning.

I'm thinking about:

  • list
  • basic fonts tags like bold, italic
  • links
  • tables

I'll take it up soon - but first I'd like to take&close this one: #93

@trincasidra
Copy link
Author

Totally agree, no worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants