Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizing GriffeLoader.allow_inspection #68

Closed
BlueGlassBlock opened this issue May 4, 2023 · 1 comment · Fixed by #69
Closed

Allow customizing GriffeLoader.allow_inspection #68

BlueGlassBlock opened this issue May 4, 2023 · 1 comment · Fixed by #69

Comments

@BlueGlassBlock
Copy link
Contributor

When utilizing native extensions, griffe will first use inspect to load native extension as a base, however that may produce confusing result by "leaking" APIs from native level, or produce confusing tag on methods/properties. So I think allowing toggling inspection is useful to make griffe only analyze modules statically.

For reference, see my testing repo: https://github.com/BlueGlassBlock/mkdocstrings-native-test

@BlueGlassBlock BlueGlassBlock changed the title Allow customizing GriffeLoader.inspect_module Allow customizing GriffeLoader.allow_inspection May 4, 2023
@pawamoy
Copy link
Member

pawamoy commented May 4, 2023

Thanks, good use-case for Griffe's allow_inspection option 👍 Thanks for the PR!

pawamoy pushed a commit that referenced this issue May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants