Skip to content
This repository has been archived by the owner on Apr 20, 2024. It is now read-only.

Migration to Vapor 3 #15

Merged
merged 14 commits into from
May 6, 2019
Merged

Migration to Vapor 3 #15

merged 14 commits into from
May 6, 2019

Conversation

cweinberger
Copy link
Contributor

@cweinberger cweinberger commented May 2, 2019 •
edited
Loading

Updates Gatekeeper for Vapor 3

Example project: https://github.com/cweinberger/gatekeeper-example-vapor

TODOS

  • Migrate to Vapor 3
  • Update CircleCI
  • Update documentation
  • Add tests
  • Create protected vapor-2 branch from master before merging

@cweinberger cweinberger changed the title Migration to Vapor 3 WIP: Migration to Vapor 3 May 2, 2019
@BrettRToomey
Copy link
Contributor

👋

@cweinberger cweinberger force-pushed the feature/migrate-to-vapor-3 branch 5 times, most recently from 21395a9 to 1e21de8 Compare May 2, 2019 20:55
@codecov
Copy link

codecov bot commented May 2, 2019 •
edited
Loading

Codecov Report

Merging #15 into master will decrease coverage by 1.26%.
The diff coverage is 98.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage     100%   98.73%   -1.27%     
==========================================
  Files           1        4       +3     
  Lines          53       79      +26     
==========================================
+ Hits           53       78      +25     
- Misses          0        1       +1
Impacted Files Coverage Δ
Sources/Gatekeeper/GatekeeperConfig.swift 100% <100%> (ø)
Sources/Gatekeeper/GatekeeperMiddleware.swift 100% <100%> (ø)
Sources/Gatekeeper/GatekeeperProvider.swift 100% <100%> (ø)
Sources/Gatekeeper/Gatekeeper.swift 97.72% <97.72%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afac054...695602e. Read the comment docs.

@cweinberger cweinberger changed the title WIP: Migration to Vapor 3 Migration to Vapor 3 May 3, 2019
@cweinberger cweinberger mentioned this pull request May 3, 2019
Closed
@cweinberger cweinberger requested a review from heidipuk May 3, 2019 06:48
@cweinberger cweinberger mentioned this pull request May 3, 2019
Closed
siemensikkema
siemensikkema reviewed May 3, 2019
View reviewed changes
Copy link
Contributor

@siemensikkema siemensikkema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a quick browse through the code. It looks very good, just a few minor comments so far.

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
Sources/Gatekeeper/Gatekeeper.swift Outdated Show resolved Hide resolved
Sources/Gatekeeper/GatekeeperMiddleware.swift Outdated Show resolved Hide resolved
siemensikkema
siemensikkema reviewed May 3, 2019
View reviewed changes
Sources/Gatekeeper/GatekeeperMiddleware.swift Outdated Show resolved Hide resolved
Tests/GatekeeperTests/GatekeeperTests.swift Outdated Show resolved Hide resolved
Tests/GatekeeperTests/GatekeeperTests.swift Outdated Show resolved Hide resolved
@cweinberger cweinberger merged commit 6892a52 into master May 6, 2019
@cweinberger cweinberger deleted the feature/migrate-to-vapor-3 branch May 6, 2019 07:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@siemensikkema siemensikkema siemensikkema approved these changes

@heidipuk heidipuk Awaiting requested review from heidipuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cweinberger @BrettRToomey @siemensikkema