-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
@madsodgaard Thank you for this well-crafted PR! I think the translation to Vapor 4 is very well done and the added customizability is more than welcome! |
@siemensikkema Great to hear! I'll get that branch merged and update the README within a few days. |
@siemensikkema Merged your changes and updated the README. Should be ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating. We're nearly there! Just a few nits in relation to the README and I discovered that .swiftpm
has been committed. Could you remove that and add .swiftpm
to .gitignore
?
@siemensikkema Done 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much! I'll release this in a minute 👌🏻
This PR adds Vapor 4 support with the following API:
Other than that it's possible to use a custom cache, but by default it uses the Vapor 4 in memory cache.
This PR also adds
GatekeeperKeyMaker
which is a protocol used to define the cache key for a specificRequest
this solves: #3By default it uses
GatekeeperHostnameKeyMaker
which uses the request hostname to generate the cache keyI still need to update the README, but the code should be ready for review.