feat: warn when installing packages with srcrefs #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be-marc
reviewed
Dec 6, 2023
|
Tested on my machine. Works. |
Co-authored-by: Marc Becker <[email protected]>
|
We solve this differently by removing srcrefs from custom_check functions and parameter values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing packages with source references and configuring objects with parameters that are functions, objects can be gigantic. Here we heuristically check whether mlr3misc is installed with srcrefs and warn if this is the case.
Note that we don't simply check for the presence of srcrefs in the attributes to avoid evaluating the promise.