Skip to content

Commit

Permalink
Update stale.yml
Browse files Browse the repository at this point in the history
  • Loading branch information
@mmistakes
mmistakes committed May 12, 2021
1 parent 4847ce3 commit 635b179
Showing 1 changed file with 5 additions and 17 deletions.
22 changes: 5 additions & 17 deletions .github/workflows/stale.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,26 +14,14 @@ jobs:
If this is a **bug** and you can still reproduce this error on the `master` branch, please reply with any additional information you have about it in order to keep the issue open.
If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.
If this is a feature request, please [add as an Idea under discussions](https://github.com/mmistakes/minimal-mistakes/discussions/categories/ideas) and elaborate on why it is core to this project and why you feel more than 80% of users would find it beneficial.
This issue will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.
stale-pr-message: |
This issue has been automatically marked as stale because it has not had recent activity.
If this is a **bug** and you can still reproduce this error on the `master` branch, please reply with any additional information you have about it in order to keep the issue open.
This pull request has been automatically marked as stale because it has not had recent activity.
If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.
This issue will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.
This pull request will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.
stale-issue-label: "Status: Stale"
exempt-issue-labels:
- "Status: Accepted"
- "Status: Under Consideration"
- "Status: Review Needed"
- "Status: In Progress"
exempt-issue-labels: "Status: Accepted,Status: Under Consideration,Status: Review Needed,Status: In Progress"
stale-pr-label: "Status: Stale"
exempt-pr-labels:
- "Status: Accepted"
- "Status: Under Consideration"
- "Status: Review Needed"
- "Status: In Progress"
exempt-pr-labels: "Status: Accepted,Status: Under Consideration,Status: Review Needed,Status: In Progress"

6 comments on commit 635b179

@iBug
Copy link
Collaborator

@iBug iBug commented on 635b179 May 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if you still have time to handle all those PRs, or will they be left stale forever?

image

@mmistakes
Copy link
Owner Author

@mmistakes mmistakes commented on 635b179 May 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More likely I’ll close most as many aren’t something I’m interested in adding.

I use the stale status to gauge interest in a PR or issue. Most are narrow focused features or requests not worth the technical debt added to the theme if I were to merge in.

@iBug
Copy link
Collaborator

@iBug iBug commented on 635b179 May 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that, but I think they should be acted upon accordingly. Here's my view:

And one last special case: #2636 (support for sverrirs/jekyll-paginate-v2) - What about just letting it in for now and let users report further issues? I've been watching this repo for like a year but haven't seen much activity recently

@mmistakes
Copy link
Owner Author

@mmistakes mmistakes commented on 635b179 May 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May appear as limited activity but I can assure you I read everything from the Jekyll/HTML/CSS questions, to feature requests, to blog update PRs sent to the wrong remote repo, and everything in between.

Lately I’ve been mostly quiet because I don’t really agree with a pull request or feature request enough to comment or close it, so I leave it be.

Hence the stale flag. If there’s enough demand or discussion around it I’m motivated to take a second look and weigh in… which rarely happens.

Usually it’s only the PR author or one other user asking for something that in the long will likely make managing things harder or clashes with my design philosophy for the theme.

At this point I’m more of in maintenance mode with it. Sure there are things I could add or improve on, but that would likely happen with a complete rethink (or fork) of the theme.

@iBug
Copy link
Collaborator

@iBug iBug commented on 635b179 May 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really appreciate how quickly you close all those wrong PRs and migrate question-type issues to discussions.

Thank you very much for your great project and promptly response. Now I get where you are by "in maintenance mode".

@rhwood
Copy link
Contributor

@rhwood rhwood commented on 635b179 May 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would much prefer comments as to why a PR is not being included than have a stale bot just automatically close it without commentary.

Please sign in to comment.