Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update giscus #4274

Merged
merged 2 commits into from
Apr 23, 2024
Merged

update giscus #4274

merged 2 commits into from
Apr 23, 2024

Conversation

akaunderr
Copy link
Contributor

This is an enhancement or feature.

Summary

New attributes for the giscus comment provider

Context

  1. Configuration attributes:
  • data-emit-metadata - Discussion metadata will be sent periodically to the parent window (the embedding page). For demonstration, enable this option and open your browser's console on this page. See the documentation for more details.
  • data-input-position - The comment input box will be placed above the comments, so that users can leave a comment without scrolling to the bottom of the discussion.
  • data-lang - Interface language.
  • data-loading - Loading of the comments will be deferred until the user scrolls near the comments container. This is done by adding loading="lazy" to the <iframe> element.
  • data-strict - Avoid mismatches due to GitHub's fuzzy searching method when there are multiple discussions with similar titles. See the documentation for more details.
  1. async - HTML attribute for the <script> tag

@iBug iBug merged commit 409bc92 into mmistakes:master Apr 23, 2024
minyoongi96 pushed a commit to minyoongi96/minyoongi96.github.io that referenced this pull request Aug 26, 2024
* update giscus

* fix site variable name

---------

Co-authored-by: Andrii Burkatskyi <underr-ua@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants