External Link icon #62
Conversation
|
Appreciate the PR but I don't think that I'm will merge it in. My taste is more minimal and simple and to keep primary navigations clean and free from distracting elements like small icons 😉 Making it something you can toggle on/off from And about iconmoon. You've just reminded me that I probably should swap out the custom build I'm using to Font Awesome instead. Will give more options for those who want to use alternative icons other than the limited set of social networking ones I've included. I'm doing this with my newer starter theme Skinny Bones... |
|
No worries. I agree with you about the clean design, for the most part. But in the case of that top nav, thought the icon was worth the "distraction". Like I said, personal preference/YMMV. Will be interested in checking out the Font Awesome stuff. I'm usually more of a server-side guy, so this is all stuff that I don't normally get to play with. Enjoying the learning experience (in spite of some hours of frustration and lack of sleep) :) |
Fix home links
Upgrade Gemfile.lock (so Jekyll >= 3.1.4) to avoid bug on page/layout metadata
Cli interface
...using the Sublime Text editor [MarkdownTOC](https://github.com/naokazuterada/MarkdownTOC) tool! Here are my user settings for it: ```json { "defaults": { "autoanchor": true, "autolink": true, "bracket": "round", "levels": [1,2,3,4,5,6], "indent": "\t", "remove_image": true, "link_prefix": "", "bullets": ["-"], "lowercase": "only_ascii", "style": "ordered", "uri_encoding": true, "markdown_preview": "" }, "id_replacements": [ { "pattern": "\\s+", "replacement": "-" }, { "pattern": "<|>|&|'|"|&mmistakes#60;|&mmistakes#62;|&mmistakes#38;|&mmistakes#39;|&mmistakes#34;|!|#|$|&|'|\\(|\\)|\\*|\\+|,|/|:|;|=|\\?|@|\\[|\\]|`|\"|\\.|\\\\|<|>|{|}|™|®|©|%", "replacement": "" } ], "logging": false } ```
Added external icon to external links in _includes/_navigation.html. Based on condition
{% if link.external %}which is already in use in the file.I prefer to see the distinction of the external links. You can see it in action at http://charliegriefer.github.io/ (note that the RSS icon you see at that site is not part of this pull request). I get that this is personal preference, and YMMV. Your call, obviously.
As an alternative, if you're not a fan of the icon always automatically showing for external links, I could add a new variable to the _config.yml that would determine whether or not to display the link.
link.display_ext_iconor some such.Also, I've never worked with icomoon before. Please feel free to verify that I didn't muck up any of the existing icons :)