feat(typegen): retain intersection types

[janpaepke]

This PR is based on the discussion here:
#386

[janpaepke]

So this works surprisingly well. So much so, that I don't fully trust I didn't overlook something.
I would ask you to test it please.

Additionally I restructured the readme quite a bit.

• I removed the redundancy of the config and cli param definitions by combining them into a table.
• added docs for this feature.

Looking through the readme now, I feel like everything that's in "Advanced Configuration" should maybe go into a separate file. What do you think?

[codecov-commenter]

Codecov Report

Merging #389 (e4b25f2) into master (32acf69) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
+ Coverage   96.69%   96.72%   +0.03%     
==========================================
  Files          32       32              
  Lines        1119     1130      +11     
  Branches      214      216       +2     
==========================================
+ Hits         1082     1093      +11     
  Misses         37       37              

Impacted Files	Coverage Δ
packages/typegen/src/write/inline.ts	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32acf69...e4b25f2. Read the comment docs.

[mmkal]

This is awesome! I think we’re gonna immediately start using the to get rid of loads of bogus nulls. Will take a closer look at the docs and details over the next day or two. Let me know if you’re still working on this - one thing that occurs to me is it’d be good to have a slightly more high level test as well. i.e. no templated params, so it’s easy to see at a glance how this feature works. I’d be happy to push this to your branch if you’re not actively reshuffling stuff - let me know.

[mmkal]

So this works surprisingly well. So much so, that I don't fully trust I didn't overlook something. I would ask you to test it please.

Additionally I restructured the readme quite a bit.

• I removed the redundancy of the config and cli param definitions by combining them into a table.
• added docs for this feature.

Looking through the readme now, I feel like everything that's in "Advanced Configuration" should maybe go into a separate file. What do you think?

I like the readme updates - I am generally not a fan of splitting readme files unless there’s a full docusaurus site because it loses cmd-f without an adequate replacement. Also just to make the diff cleaner, what do you think about pushing in the unrelated readme changes first so it’s easy to look back at this PR and see what was added?

[janpaepke]

Hey Misha,
sure, I apologise for falling into my bad habbit of "while I'm at this, I might as well do that".
You're right, it should have been a separate PR, even though the changes in the readme are in distinct sections, there is no overlap. Look here for the config only changes and here to preview the new readme.

The docs for the new feature are here.

Re tests: sure, have a go! Don't worry, I can keep my hands busy elsewhere. ;)

[janpaepke]

Damn it, I found a caveat.
Intersecting the types will drop the comments.
So basically you lose the info what column the property comes from, which typegen graciously tells you.

Off the top of my head I don't have a solution. Do you?

edit: forget what I said. I was being stupid.

[janpaepke]

Sooo. Is this good to go?

[mmkal]

🎉