Sebastian's review

mnajdova · Jan 14, 2021 · 6e25d37 · 6e25d37
1 parent 747801f
commit 6e25d37
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/packages/material-ui-utils/src/requirePropFactory.d.ts b/packages/material-ui-utils/src/requirePropFactory.d.ts
@@ -1,3 +1,3 @@
-type Component = (arg: any) => any & { propTypes?: object };
+import * as React from 'react';
 
-export default function requirePropFactory(componentNameInError: string, Component?: Component): any;
+export default function requirePropFactory(componentNameInError: string, Component?: React.ComponentType): any;
diff --git a/packages/material-ui-utils/src/requirePropFactory.js b/packages/material-ui-utils/src/requirePropFactory.js
@@ -12,12 +12,11 @@ export default function requirePropFactory(componentNameInError, Component) {
   ) => {
     const propFullNameSafe = propFullName || propName;
 
-    const defaultPropType = Component?.propTypes?.[propFullNameSafe];
-    let defaultPropTypeVal = null;
+    const defaultTypeChecker = Component?.propTypes?.[propFullNameSafe];
+    let defaultTypeCheckerResult = null;
 
-    if(defaultPropType) {
-      console.log("Default prop type existed");
-      defaultPropTypeVal = defaultPropType(props, propName, componentName, location, propFullName)
+    if(defaultTypeChecker) {
+      defaultTypeCheckerResult = defaultTypeChecker(props, propName, componentName, location, propFullName)
     }
 
     if (typeof props[propName] !== 'undefined' && !props[requiredProp]) {
@@ -27,7 +26,7 @@ export default function requirePropFactory(componentNameInError, Component) {
       );
     }
 
-    return defaultPropTypeVal;
+    return defaultTypeCheckerResult;
   };
   return requireProp;
 }