Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch build backend to hatchling #825

Merged
merged 4 commits into from
Dec 8, 2023
Merged

Conversation

hoechenberger
Copy link
Member

@hoechenberger hoechenberger commented Dec 8, 2023

Before merging …

  • Changelog has been updated (docs/source/changes.md)

cc @ofek in case you're interested :)

@hoechenberger hoechenberger marked this pull request as ready for review December 8, 2023 11:46
pyproject.toml Outdated
"/.*",
"/codecov.yml",
"**/tests",
"/docs",
Copy link
Member Author

@hoechenberger hoechenberger Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ofek I'm explicitly excluding /docs here, but /docs/source/examples/gen_examples.py is still being packaged when I build the sdist. Any idea why that's happening? It's the only file in /docs that gets packaged.

Copy link
Member Author

@hoechenberger hoechenberger Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! There's an entry in .gitignore:

!docs/source/examples/gen_examples.py

This explains it.

@hoechenberger
Copy link
Member Author

hoechenberger commented Dec 8, 2023

CI error due to packaging bug in MNE: forgot to include a file in the sdist

Highlights that we should run out test suites on the installed packages and not on the checked-out repository.

Cc @cbrnr

@hoechenberger
Copy link
Member Author

CI error due to packaging bug in MNE: forgot to include a file in the sdist

Highlights that we should run out test suites on the installed packages and not on the checked-out repository.

Cc @cbrnr

See also mne-tools/mne-bids#1206

Cc @drammock

hoechenberger added a commit to hoechenberger/mne-python that referenced this pull request Dec 8, 2023
Fixes packaging bug introduced in mne-tools#12269

Addresses the issues raised in:
mne-tools/mne-bids-pipeline#825 (comment)

mne-tools/mne-bids#1206 (comment)

Ultimately, we should start testing the installed package(s), not simply
fire up the tests from the root of the checked-out repo.
hoechenberger added a commit to hoechenberger/mne-python that referenced this pull request Dec 8, 2023
Fixes packaging bug introduced in mne-tools#12269

Addresses the issues raised in:
mne-tools/mne-bids-pipeline#825 (comment)

mne-tools/mne-bids#1206 (comment)

Ultimately, we should start testing the installed package(s), not simply
fire up the tests from the root of the checked-out repo.
@hoechenberger hoechenberger reopened this Dec 8, 2023
@hoechenberger
Copy link
Member Author

@larsoner i think this is good to go

@larsoner larsoner merged commit a6995ab into mne-tools:main Dec 8, 2023
56 checks passed
@larsoner
Copy link
Member

larsoner commented Dec 8, 2023

Nice @hoechenberger !

@hoechenberger hoechenberger deleted the hatchling branch December 8, 2023 23:04
larsoner added a commit to larsoner/mne-bids-pipeline that referenced this pull request Jan 22, 2024
* upstream/main:
  [pre-commit.ci] pre-commit autoupdate (mne-tools#830)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#829)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#828)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#827)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#826)
  Switch build backend to hatchling (mne-tools#825)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants