Drop support for Python 3.9, drop Optional and Union from type hints
#908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoechenberger
force-pushed
the
hoechenberger/issue906
branch
from
19a2322
to
7d74f45
Compare
|
Diff for the config file really shows how much more readable things are now: |
|
@larsoner I assume this line / regexp needs to be changed: to accommodate the way the type for noise_cov: (
...
) = ...But I couldn't get it to work so far :( |
larsoner
reviewed
Mar 27, 2024
Comment on lines
+102
to
+111
| "^" # The line starts, then is followed by | ||
| r"(\w+): " # annotation syntax (name captured by the first group), | ||
| "(?:" # then the rest of the line can be (in a non-capturing group): | ||
| ".+ = .+" # 1. a standard assignment | ||
| "|" # 2. or | ||
| r"Literal\[" # 3. the start of a multiline type annotation like "a: Literal[" | ||
| "|" # 4. or | ||
| r"\(" # 5. the start of a multiline 3.9+ type annotation like "a: (" | ||
| ")" # Then the end of our group | ||
| "$", # and immediately the end of the line. |
There was a problem hiding this comment.
@hoechenberger this should work, make more sense?
|
Marking for merge-when-green, we'll see if my |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #906
@larsoner I simply had to change the min. Python version in
pyproject.tomland runruff; only two additional manual interventions were required after that. Super nice.Before merging …
docs/source/changes.md)