Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging output when rejecting epochs; and log number of reconstructed ICA and SSP epochs #936

Merged
merged 5 commits into from
Apr 24, 2024

Conversation

hoechenberger
Copy link
Member

@hoechenberger hoechenberger commented Apr 23, 2024

quite some duplication … but Logging is better

┌────────┬ preprocessing/_09_ptp_reject ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
│21:45:35│ ⏳️ sub-005 Input:  sub-005_task-tasin_proc-ica_epo.fif
│21:45:35│ ⏳️ sub-005 Output: sub-005_task-tasin_proc-clean_epo.fif
│21:45:36│ ⏳️ sub-005 Removed 4 of 240 epochs via PTP rejection thresholds: {'eeg': 0.00025}
│21:45:36│ ⏳️ sub-005 Adding cleaned epochs to report.

Before merging …

  • Changelog has been updated (docs/source/changes.md)

@hoechenberger hoechenberger changed the title Improve logging output when rejecting epochs Improve logging output when rejecting epochs; and log number of reconstructed ICA and SSP epochs Apr 23, 2024
@larsoner
Copy link
Member

Same failure on three CIs @hoechenberger

https://app.circleci.com/pipelines/github/mne-tools/mne-bids-pipeline/4521/workflows/7b628b2f-557d-4b5e-99fc-8ca9cfc39212/jobs/65183

You know how to raise this as an issue with the OpenNeuro folks?

@hoechenberger
Copy link
Member Author

Same failure on three CIs @hoechenberger

https://app.circleci.com/pipelines/github/mne-tools/mne-bids-pipeline/4521/workflows/7b628b2f-557d-4b5e-99fc-8ca9cfc39212/jobs/65183

You know how to raise this as an issue with the OpenNeuro folks?

Yes I can take care of this tomorrow!

Any input on this PR content?

It's not DRY at all, but I'm also not convinced that adding yet another helper function would be beneficial – the pipeline complexity is already too much for me sometimes :(

@larsoner
Copy link
Member

Looks reasonable to me so far. I don't see a convincingly cleaner way to make it more DRY anyway

@hoechenberger hoechenberger marked this pull request as ready for review April 24, 2024 09:49
@hoechenberger hoechenberger enabled auto-merge (squash) April 24, 2024 09:51
@hoechenberger
Copy link
Member Author

@larsoner I marked this for auto-merge, I hope this is okay with you! Otherwise feel free to let me know and I can revert.

@hoechenberger
Copy link
Member Author

@larsoner Tracking the OpenNeuro issue at OpenNeuroOrg/openneuro#3033

auto-merge was automatically disabled April 24, 2024 13:07

Pull Request is not mergeable

@larsoner
Copy link
Member

Failure is just downloading 246 and I can't imagine that would fail given the others passed with these changes so I'll merge, thanks @hoechenberger !

@larsoner larsoner merged commit 4d3a878 into mne-tools:main Apr 24, 2024
47 of 49 checks passed
@hoechenberger hoechenberger deleted the epochs-reject-logging branch April 24, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants