Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Bump to pybv 0.7.3 #1011

Merged
merged 7 commits into from
Jun 4, 2022
Merged

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Jun 2, 2022

PR Description

There were some failures in a recent scheduled CI run. Here I want to test how the recent pybv upgrades play into that.

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • PR description includes phrase "closes <#issue-number>"

@sappelhoff
Copy link
Member Author

failures were due to pybv, fixed in bids-standard/pybv#92 ... now waiting for the 0.7.3 release on conda-forge: conda-forge/pybv-feedstock#16

@sappelhoff sappelhoff changed the title try pybv 0.7.2 Bump to pybv 0.7.3 Jun 4, 2022
@codecov
Copy link

Codecov bot commented Jun 4, 2022

Codecov Report

Merging #1011 (4a31f42) into main (fa7a94b) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1011      +/-   ##
==========================================
- Coverage   95.20%   95.17%   -0.03%     
==========================================
  Files          25       25              
  Lines        3772     3775       +3     
==========================================
+ Hits         3591     3593       +2     
- Misses        181      182       +1     
Impacted Files Coverage Δ
mne_bids/write.py 97.14% <ø> (ø)
mne_bids/config.py 97.61% <100.00%> (+0.02%) ⬆️
mne_bids/copyfiles.py 97.61% <0.00%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa7a94b...4a31f42. Read the comment docs.

@sappelhoff sappelhoff changed the title Bump to pybv 0.7.3 [MRG] Bump to pybv 0.7.3 Jun 4, 2022
@sappelhoff sappelhoff added this to the 0.11 milestone Jun 4, 2022
@sappelhoff
Copy link
Member Author

@hoechenberger please merge if you are also happy :)

@hoechenberger hoechenberger merged commit 87ba2e9 into mne-tools:main Jun 4, 2022
@hoechenberger
Copy link
Member

Thanks @sappelhoff!

@sappelhoff sappelhoff deleted the pybv/export branch June 4, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants