Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Inspector tests for Matplotlib 3.6 compatibility #1069

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

hoechenberger
Copy link
Member

@hoechenberger hoechenberger commented Sep 28, 2022

Fixes #1068

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

@hoechenberger
Copy link
Member Author

Failing tests must be fixed upstream in MNE.

@sappelhoff
Copy link
Member

the doc build issue is due to mne-tools/mne-python#11207

I'll try to push a fix here

@sappelhoff
Copy link
Member

@hoechenberger feel free to take out of draft status and merge when you are ready :-)

thanks for the fix

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #1069 (b67548f) into main (22cbd10) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1069   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files          24       24           
  Lines        3835     3835           
=======================================
  Hits         3644     3644           
  Misses        191      191           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hoechenberger
Copy link
Member Author

I don't have time to work on the upstream changes. We can just leave this PR open until stuff gets fixed upstream, or we merge to already reduce the number of failing tests we see here. WDYT?

@sappelhoff sappelhoff marked this pull request as ready for review September 29, 2022 10:10
@sappelhoff sappelhoff merged commit 7be49cf into mne-tools:main Sep 29, 2022
@sappelhoff
Copy link
Member

merging, this is totally fine - thanks

@hoechenberger hoechenberger deleted the hoechenberger/issue1068 branch September 29, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

key_press_event is deprecated, needs to be replaced in our code
2 participants