Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MRG: Fix writing preloaded data of a non-BIDS format with automated format conversion #1102

Merged
merged 8 commits into from
Nov 20, 2022
Merged

MRG: Fix writing preloaded data of a non-BIDS format with automated format conversion #1102

merged 8 commits into from
Nov 20, 2022

Conversation

hoechenberger
Copy link
Member

@hoechenberger hoechenberger commented Nov 18, 2022 •
edited
Loading

Fixes #1101

@dengemann Can you give this a try?

PR Description

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

@codecov
Copy link

codecov bot commented Nov 18, 2022 •
edited
Loading

Codecov Report

Merging #1102 (77c1523) into main (1b04da8) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1102      +/-   ##
==========================================
+ Coverage   95.22%   95.24%   +0.02%     
==========================================
  Files          24       24              
  Lines        3873     3873              
==========================================
+ Hits         3688     3689       +1     
+ Misses        185      184       -1
Impacted Files Coverage Δ
mne_bids/write.py 97.29% <100.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hoechenberger hoechenberger marked this pull request as ready for review November 18, 2022 15:15
@hoechenberger
Copy link
Member Author

Not sure why that one CI job failed, I just restarted it. Let's see…

@hoechenberger
Copy link
Member Author

Found the problem. Should pass now!!

@hoechenberger hoechenberger changed the title Fix writing preloaded data of a non-BIDS format with automated format conversion MRG: Fix writing preloaded data of a non-BIDS format with automated format conversion Nov 20, 2022
@hoechenberger
Copy link
Member Author

@agramfort @sappelhoff Feel free to merge once green, or enable automerge :)

adam2392
adam2392 approved these changes Nov 20, 2022
View reviewed changes
Copy link
Member

@adam2392 adam2392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@agramfort agramfort merged commit b97ce0b into mne-tools:main Nov 20, 2022
@agramfort
Copy link
Member

thx @hoechenberger

@dengemann
Copy link
Member

Thanks everyone!!

@hoechenberger hoechenberger deleted the hoechenberger/issue1101 branch November 20, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dengemann dengemann dengemann left review comments

@agramfort agramfort agramfort approved these changes

@adam2392 adam2392 adam2392 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENH: fix manufacturer checking in _channels_tsv()
4 participants
@hoechenberger @agramfort @dengemann @adam2392