Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix version dropdown + misc maintenance #1142

Merged
merged 5 commits into from
May 30, 2023
Merged

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented May 30, 2023

PR Description

fixes #1138

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

doc/conf.py Outdated Show resolved Hide resolved
@codecov
Copy link

Codecov bot commented May 30, 2023

Codecov Report

Merging #1142 (64430e0) into main (0193219) will not change coverage.
The diff coverage is n/a.

❗ Current head 64430e0 differs from pull request most recent head 1f9f6ff. Consider uploading reports for the commit 1f9f6ff to get more accurate results

@@           Coverage Diff           @@
##             main    #1142   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files          40       40           
  Lines        8577     8577           
=======================================
  Hits         8371     8371           
  Misses        206      206           

@sappelhoff sappelhoff changed the title fix version dropdown fix version dropdown + misc maintenance May 30, 2023
@@ -158,6 +158,8 @@ authors:
- given-names: Fesselier
family-names: Laetitia
affiliation: 'McGill Centre for Integrative Neuroscience, McGill University, Montreal, Canada'
- given-names: Jonathan
family-names: Vanhoecke
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JonathanVHoecke we forgot to add you to this list earlier when you made your first PR! Can you please tell us your affiliation and ORCID?

Same goes for @richardkoehler -- we still need your affiliation and ORCID

Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sappelhoff
Sorry, I must have overlooked that so thanks for the notice!

I am currently listed under:

  - given-names: Richard
    family-names: Koehler
    orcid: 'https://orcid.org/0000-0002-5219-1289'

The ORCID is correct, but if possible it would be kind if you could modify given and family-names and add the affiliation like below (changed fields in bold). Or should I add the changes in a PR myself? Thanks in advance!

  - given-names: Richard M.
    family-names: Köhler
    orcid: 'https://orcid.org/0000-0002-5219-1289'
    affilitation: Movement Disorder and Neuromodulation Unit, Department of Neurology, Charité – Universitätsmedizin Berlin, Germany

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardkoehler could you please prepare one PR with both yours and @JonathanVHoecke's information? I see that you are colleagues (if your website is up to date).

Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @sappelhoff . Yes we will do. I will also get back on de PR about sessions.tsv as I unfortunately did not manage before my holidays.
Many thanks again, bw
Jonathan

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will also get back on de PR about sessions.tsv

That one has already been merged 😅

sappelhoff and others added 3 commits May 30, 2023 11:07
Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
@sappelhoff sappelhoff merged commit a19b20f into mne-tools:main May 30, 2023
@sappelhoff sappelhoff deleted the docs/fix branch May 30, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: dropdown menu on main no longer working
4 participants