[MRG] Adding updated tutorial to mention BIDS vs mne coordinate systems.

[adam2392]

PR Description

Closes: #715

To work on after #704 is merged.

Merge checklist

Maintainer, please confirm the following before merging:

• All comments resolved
• This is not your own PR
• All CIs are happy
• PR title starts with [MRG]
• whats_new.rst is updated
• PR description includes phrase "closes <#issue-number>"

[hoechenberger]

Awesome, @adam2392! Ping me when you want some feedback

[adam2392]

https://4136-89170358-gh.circle-artifacts.com/0/dev/auto_examples/convert_ieeg_to_bids.html#sphx-glr-auto-examples-convert-ieeg-to-bids-py

how's this for first pass?

Once CI passes, then it's just however we want to describe these issues in this tutorial.

[adam2392]

@hoechenberger any issues w/ this?

[hoechenberger]

There's a rendering issue:

And you're sometimes talking about "MNE", sometimes about "MNE-Python"; I think this can be made more consistent :)

Also I think this important info is somehow getting lost, being buried down there at the very end of the tutorial. Can we maybe move it up somehow? I think it deserves its own Info Box or something…

[adam2392]

There's a rendering issue:

Why are my sphinx/rst skills so subpar :(.

And you're sometimes talking about "MNE", sometimes about "MNE-Python"; I think this can be made more consistent :)

Also I think this important info is somehow getting lost, being buried down there at the very end of the tutorial. Can we maybe move it up somehow? I think it deserves its own Info Box or something…

agreed. Will adjust

[hoechenberger]

Why are my sphinx/rst skills so subpar :(.

Because RST is a horrible standard and Sphinx syntax is just as horrible too 🤯 My personal opinion ;)

[codecov-io]

Codecov Report

Merging #717 (27af1bb) into master (a45695e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #717   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files          23       23           
  Lines        2759     2759           
=======================================
  Hits         2591     2591           
  Misses        168      168           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a45695e...29cef07. Read the comment docs.

[sappelhoff]

@adam2392 I think this should work.

[sappelhoff]

Don't forget to add this to the bottom of the file after merging my two suggestions.

.. _appendix VIII: https://bids-specification.readthedocs.io/en/stable/99-appendices/08-coordinate-systems.html
.. _background on FreeSurfer: https://mne.tools/dev/auto_tutorials/source-modeling/plot_background_freesurfer_mne
.. _MNE-Python coordinate frames: https://mne.tools/dev/auto_tutorials/source-modeling/plot_source_alignment.html

[sappelhoff]

sometimes it's better to commit, then to comment and ask somebody to commit something :-D

[adam2392]

sometimes it's better to commit, then to comment and ask somebody to commit something :-D

Thanks!

[adam2392]

Is there a reason it's not showing up in our renderings: https://mne.tools/mne-bids/dev/auto_examples/convert_ieeg_to_bids.html#

[sappelhoff]

Is there a reason it's not showing up in our renderings: https://mne.tools/mne-bids/dev/auto_examples/convert_ieeg_to_bids.html#

fixed in df53001