MAINT: Fix bugs with code credit and linking #12820
Conversation
larsoner
requested review from
drammock,
agramfort and
dengemann
as code owners
doc/sphinxext/credit_tools.py
Outdated
| "Drew, J.": "Jordan Drew", # 10861 | ||
| "Hamid": "Hamid Maymandi", # 10849 | ||
| "jwelzel": "Julius Welzel", # 11118 | ||
| "Jean-Rémi King": "Jean-Rémi King", |
There was a problem hiding this comment.
this one looks vacuous, maybe a "find/replace-all" mistake?
doc/sphinxext/credit_tools.py
Outdated
| @@ -84,6 +126,18 @@ def generate_credit_rst(app=None, *, verbose=False): | |||
|
|
|||
| unknown_emails: set[str] = set() | |||
|
|
|||
| # Use doc/changes/*.rst to map PR numbers to names | |||
There was a problem hiding this comment.
a bit concerned about this, as (1) authors listed in changelog won't necessarily match those in Co-authored-by commit trailers, and (2) for older changelog entries, we must take in on faith that the PR number was entered correctly.
|
hmm, looks like the |
|
Comments addressed, removed the problematic changelog parsing, and pushed a simple fix for conftest (no need to specify the warning type, the regex is targeted enough) so marking for merge-when-green! |
Closes #12817
Closes #12818
Also fix the neo part of https://app.circleci.com/pipelines/github/mne-tools/mne-python/25126/workflows/44f5e760-f46a-4e48-8a46-775135dcee05/jobs/68338, need to wait for Dipy to push out new wheels for other fixes.