Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated dependency works fine support for React 18.3.1 #76

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

parthamk
Copy link

Dear maintainer of this package I have updated the dependency now the package supports react 18.3.1 along with all other packages have been updated please check and merge it.

Thank you

@parthamk parthamk changed the title updated dependency works fine updated dependency works fine support for React 18.3.1 Jun 17, 2024
@georgeOsdDev
Copy link
Member

Hi @parthamk
Thank you for you great work!
Unfortunately I'm not a maintainer of this project now. please contact https://github.com/mobilusoss to proceed this PR.
I think @mobilusuzun may help you.

@parthamk
Copy link
Author

Thanks, I am making more changes recently updated peerDependency creating another fixed pull request.

@parthamk
Copy link
Author

fixed peerDependency and other minor issues. @mobilusuzun please check and merge it.

@mobilusuzun
Copy link

@parthamk (@georgeOsdDev)
Thank you for your contrubution!
The project is not actively maintained right now. It is currently being reorganized and will probably take some time.

@parthamk
Copy link
Author

parthamk commented Jul 3, 2024

Hey mobilusuzun,

Thank you, I assure you all the features are working fine. I have build my own npm named package with the exact code of your repo and it works fine.

Here is my named package on npmjs.com:
https://www.npmjs.com/package/@parthamk/notification-badge

Here is the project I was working with "react-notification-badge" now using my own named package it works as well.
https://github.com/parthamk/realtime-chat-application

I am writing you this so that you know it works.

Thank you..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants