dockerfile: avoid frontend panic when no stages defined #5150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Jul 10, 2024
| @@ -5479,6 +5480,40 @@ RUN echo $(hostname) | grep foo | |||
| } | |||
| } | |||
|
|
|||
| func testEmptyStages(t *testing.T, sb integration.Sandbox) { | |||
| integration.SkipOnPlatform(t, "windows") | |||
There was a problem hiding this comment.
Just a default atm. There is a separate task to enable integration tests one-by-one in wcow. Not specific to the feature.
AkihiroSuda
reviewed
Jul 10, 2024
AkihiroSuda
approved these changes
Jul 10, 2024
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
dockerfile-no-stage-error
branch
from
732981a
to
262634c
Compare
AkihiroSuda
approved these changes
Jul 10, 2024
jsternberg
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5147
Although #5147 does not list Dockerfile, this is the only case I see where this was possible. Build without stages is still error, but don't let the frontend panic.