Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerfile: mask usage of secret env in command name #5336

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

tonistiigi
Copy link
Member

Replace variables with **** if they are used as secret env.

This is not needed to not leak secret values but to make sure output does not contain some incorrect default value.

Noticed via #5333 (@dvdksn @ryio1010)

Replace variables with **** if they are used as secret env.

This is not needed to not leak secret values but to make
sure output does not contain some incorrect default value.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@thompson-shaun thompson-shaun added this to the v0.17.0 milestone Sep 16, 2024
@tonistiigi tonistiigi merged commit 3953dc7 into moby:master Sep 17, 2024
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants