Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal improvments #4563

Merged
merged 3 commits into from
Mar 11, 2014
Merged

Signal improvments #4563

merged 3 commits into from
Mar 11, 2014

Conversation

creack
Copy link
Contributor

@creack creack commented Mar 10, 2014

Move signal to pkg + use strings instead of signal number to allow cross platform signal forwarding. An error is thrown in case of unknown signal.

@creack
Copy link
Contributor Author

creack commented Mar 10, 2014

@vieux
Copy link
Contributor

vieux commented Mar 10, 2014

LGTM

@crosbymichael
Copy link
Contributor

@creack DCO failed

@tianon
Copy link
Member

tianon commented Mar 11, 2014

+1 me gusta - now we don't have to hard-code the raw integer mappings for ourselves just for the client, and third-party clients will have an easier time using the signalling

@tianon
Copy link
Member

tianon commented Mar 11, 2014

Do those constants in "pkg/signal" (the syscall.* ones) map cleanly on other hosts? Or are you thinking about future non-Linux daemons way down the road there?

@creack
Copy link
Contributor Author

creack commented Mar 11, 2014

@tianon It is a basic copy/paste from the syscall package from the different platform. So they map to their host.
I didn't think about non-linux daemon, but it should work fine. Small reserve on windows client though, but we'll see once we get there.

Docker-DCO-1.1-Signed-off-by: Guillaume J. Charmes <guillaume@charmes.net> (github: creack)
Docker-DCO-1.1-Signed-off-by: Guillaume J. Charmes <guillaume@charmes.net> (github: creack)
Docker-DCO-1.1-Signed-off-by: Guillaume J. Charmes <guillaume@charmes.net> (github: creack)
@creack
Copy link
Contributor Author

creack commented Mar 11, 2014

@crosbymichael DCO fixed

@tianon
Copy link
Member

tianon commented Mar 11, 2014

cool, SGTM 👍

@crosbymichael
Copy link
Contributor

LGTM

crosbymichael added a commit that referenced this pull request Mar 11, 2014
@crosbymichael crosbymichael merged commit b5a544b into moby:master Mar 11, 2014
@creack creack deleted the signal-improvment branch March 11, 2014 01:00
@unclejack unclejack added this to the 0.9.1 milestone Mar 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants