-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signal improvments #4563
Signal improvments #4563
Conversation
LGTM |
@creack DCO failed |
+1 me gusta - now we don't have to hard-code the raw integer mappings for ourselves just for the client, and third-party clients will have an easier time using the signalling |
Do those constants in "pkg/signal" (the syscall.* ones) map cleanly on other hosts? Or are you thinking about future non-Linux daemons way down the road there? |
@tianon It is a basic copy/paste from the syscall package from the different platform. So they map to their host. |
Docker-DCO-1.1-Signed-off-by: Guillaume J. Charmes <guillaume@charmes.net> (github: creack)
Docker-DCO-1.1-Signed-off-by: Guillaume J. Charmes <guillaume@charmes.net> (github: creack)
Docker-DCO-1.1-Signed-off-by: Guillaume J. Charmes <guillaume@charmes.net> (github: creack)
@crosbymichael DCO fixed |
cool, SGTM 👍 |
LGTM |
Move signal to pkg + use strings instead of signal number to allow cross platform signal forwarding. An error is thrown in case of unknown signal.