mountinfo: use idiomatic naming for fields #34
Conversation
thaJeztah
force-pushed
the
idiomatic_naming
branch
from
aba738a
to
4661a4b
Compare
|
I tend to agree the new names are better, and guess we can convert existing users. 👍 |
|
This will only be problematic for repos which use bots to update dependencies (and only if their maintainers ignore CI failures) |
|
Can you please rename |
|
Alternatively, of course, we can modify containerd to expect these fields. I'm not sure which way is better. |
thaJeztah
force-pushed
the
idiomatic_naming
branch
2 times, most recently
from
b5f7760
to
7b71b2d
Compare
I am looking at using these modules in containerd, so that we can reduce the effort of maintaining "mountinfo" implementations. This change renames the info fields to match the ones used in containerd, which are more "correct" from a Go naming perspective: containerd/containerd@8cd2182 This will be a breaking changes for consumers of this package, but we're still pre-v1.0.0, so if we want to make these changes, this is still possible now. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
idiomatic_naming
branch
from
7b71b2d
to
3f9aa13
Compare
|
Rebased 👍 ptal |
Ah, we forgot about this one, and surely I found it a minute after I cut a release :( |
oh! Sorry, good catch, looks like I missed that comment; thanks for fixing in #41 |
follow-up to #32
I am looking at using these modules in containerd, so that we can reduce the effort of maintaining "mountinfo" implementations.
This change renames the info fields to match the ones used in containerd, which are more "correct" from a Go naming perspective: containerd/containerd@8cd2182
This will be a breaking changes for consumers of this package, but we're still pre-v1.0.0, so if we want to make these changes, this is still possible now.