Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signal: add lcow supported signals to windows signal map #98

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

katiewasnothere
Copy link
Contributor

This PR addresses the issues discussed in containerd/containerd#6002 to support linux signals for LCOW.

Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com

Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
@katiewasnothere
Copy link
Contributor Author

@dmcgowan @jterry75 @kzys FYI

Copy link

@jterry75 jterry75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@katiewasnothere
Copy link
Contributor Author

@samuelkarp Does this PR need another sign off? Is there anything blocking merging it?

@samuelkarp
Copy link
Member

Yes, generally two maintainer LGTMs.

@katiewasnothere
Copy link
Contributor Author

@thaJeztah could you take a look when you get the chance?

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sorry, I somehow missed this one 😅

@thaJeztah thaJeztah merged commit 74ec3fe into moby:master Jan 27, 2022
@thaJeztah thaJeztah changed the title Add lcow supported signals to windows signal map signal: add lcow supported signals to windows signal map Feb 3, 2022
@katiewasnothere katiewasnothere deleted the windows_lcow_signals branch February 23, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants