Set bool on proto that we want all logs

modal-labs · Jul 12, 2024 · 71e429a · 71e429a
1 parent bfc10f5
commit 71e429a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/modal/image.py b/modal/image.py
@@ -1679,7 +1679,9 @@ def run_inside(self):
     async def logs(self) -> AsyncGenerator[str, None]:
         last_entry_id: Optional[str] = None
 
-        request = api_pb2.ImageJoinStreamingRequest(image_id=self._object_id, timeout=55, last_entry_id=last_entry_id)
+        request = api_pb2.ImageJoinStreamingRequest(
+            image_id=self._object_id, timeout=55, last_entry_id=last_entry_id, include_logs_for_finished=True
+        )
         async for response in unary_stream(self._client.stub.ImageJoinStreaming, request):
             if response.result.status:
                 return

diff --git a/modal_proto/api.proto b/modal_proto/api.proto
@@ -1359,6 +1359,7 @@ message ImageJoinStreamingRequest {
   string image_id = 1;
   float timeout = 2;
   string last_entry_id = 3;
+  bool include_logs_for_finished = 4;
 }
 
 message ImageJoinStreamingResponse {