Stop heartbeats before snapshotting

modal-labs · Jul 12, 2024 · f3c04c6 · f3c04c6
1 parent 2f73121
commit f3c04c6
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/modal/_container_io_manager.py b/modal/_container_io_manager.py
@@ -609,6 +609,9 @@ async def memory_snapshot(self) -> None:
         if self.checkpoint_id:
             logger.debug(f"Checkpoint ID: {self.checkpoint_id} (Memory Snapshot ID)")
 
+        # Heartbeats can leave the modal.sock file open, causing gVisor to crash
+        self.stop_heartbeat()
+
         await self._client.stub.ContainerCheckpoint(
             api_pb2.ContainerCheckpointRequest(checkpoint_id=self.checkpoint_id)
         )