Add max_batch_inputs and block_duration to message Function #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwaskom
reviewed
Jul 6, 2024
| @@ -941,6 +941,9 @@ message Function { | |||
|
|
|||
| string use_function_id = 54; // for class methods use this function id instead for invocations - the *referenced* function should have is_class=True | |||
| string use_method_name = 55; // for class methods - this method name needs to be included in the FunctionInput | |||
|
|
|||
| int32 max_batch_inputs = 56; // Maximum number of inputs per batch | |||
| float block_duration = 57; // Time to block before a response is needed | |||
There was a problem hiding this comment.
Should we put the units in the field name, or failing that, the comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Protoc changes to to support batching
Backward/forward compatibility checks
Check these boxes or delete any item (or this section) if not relevant for this PR.
Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.