Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batching: Protobuf Changes to Function and FunctionGetInputsRequest #1998

Merged
merged 7 commits into from
Jul 15, 2024
Merged

Batching: Protobuf Changes to Function and FunctionGetInputsRequest #1998

merged 7 commits into from
Jul 15, 2024

Conversation

cathyzbn
Copy link
Contributor

@cathyzbn cathyzbn commented Jul 11, 2024 •
edited
Loading

Describe your changes

Adding batching parameters batch_max_size and batch_linger_secs to FunctionGetInputsRequest

Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.

@cathyzbn cathyzbn changed the title Add batching params to FunctionGetInputsRequest Batching: add params to FunctionGetInputsRequest Jul 11, 2024
@cathyzbn cathyzbn changed the title Batching: add params to FunctionGetInputsRequest Batching: add params to Function and FunctionGetInputsRequest Jul 11, 2024
@cathyzbn cathyzbn requested a review from gongy July 11, 2024 14:40
@cathyzbn cathyzbn marked this pull request as ready for review July 11, 2024 14:41
@cathyzbn cathyzbn changed the title Batching: add params to Function and FunctionGetInputsRequest Batching: Protobuf Changes to Function and FunctionGetInputsRequest Jul 11, 2024
gongy
gongy approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@gongy gongy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can get away without optional -- otherwise lgtm

@cathyzbn cathyzbn merged commit eb32df7 into main Jul 15, 2024
22 checks passed
@cathyzbn cathyzbn deleted the cathy/batch_function_get_inputs_protobuf branch July 15, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gongy gongy gongy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cathyzbn @gongy