New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: cleanup proto enum #2003

Merged

thundergolfer merged 1 commit into main from jonathon/cleanup-enum-jul11

Jul 12, 2024

Contributor

thundergolfer commented Jul 12, 2024

Backward/forward compatibility checks

Client+Server: this change is compatible with old servers
- the server doesn't send this value to the client, and reducing enum scope is compatible with old servers.
Client forward compatibility: this change ensures client can accept data intended for later versions of itself
- the client doesn't receive this enum value from the server


          internal: cleanup proto enum

modal-pr-review-automation bot approved these changes

View reviewed changes

modal-pr-review-automation bot left a comment

Auto-approved 👍. This diff qualified for automatic approval and doesn't need follow up review.

thundergolfer merged commit bd5d738 into main

23 checks passed

thundergolfer deleted the jonathon/cleanup-enum-jul11 branch

July 12, 2024 14:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet