Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOD-3251] Stop heartbeats before sending the container snapshot RPC #2004

Merged
merged 28 commits into from
Jul 16, 2024
Merged

[MOD-3251] Stop heartbeats before sending the container snapshot RPC #2004

merged 28 commits into from
Jul 16, 2024

Commits on Jul 12, 2024

  1. Stop heartbeats before snapshotting

    @mattnappo
    mattnappo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    f3c04c6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into matt/gvisor-flake-fix

    @thundergolfer
    thundergolfer committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    41adde8 View commit details
    Browse the repository at this point in the history

  3. Added asyncio.Event for pausing heartbeats

    @mattnappo
    mattnappo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    4cceb72 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'matt/gvisor-flake-fix' of github.com:modal-labs/modal-c… 

    …lient into matt/gvisor-flake-fix
    @mattnappo
    mattnappo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    2cdcd60 View commit details
    Browse the repository at this point in the history

  5. Use asyncio.Condition to ensure mutual exclusion

    @mattnappo
    mattnappo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    626af1c View commit details
    Browse the repository at this point in the history

  6. Fixed unit tests

    @mattnappo
    mattnappo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    7228652 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Merge branch 'main' of github.com:modal-labs/modal-client into matt/g… 

    …visor-flake-fix
    @mattnappo
    mattnappo committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    b0bef65 View commit details
    Browse the repository at this point in the history

  2. Fixed bug, but now its slow

    @mattnappo
    mattnappo committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    86b8fd5 View commit details
    Browse the repository at this point in the history

  3. Fixed bottleneck

    @mattnappo
    mattnappo committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    4c6ed72 View commit details
    Browse the repository at this point in the history

  4. Remove old logic

    @mattnappo
    mattnappo committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    096a399 View commit details
    Browse the repository at this point in the history

  5. Renamed cond var

    @mattnappo
    mattnappo committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    bf5400b View commit details
    Browse the repository at this point in the history

  6. Wrote tests

    @mattnappo
    mattnappo committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    484e24d View commit details
    Browse the repository at this point in the history

  7. Wrote better tests

    @mattnappo
    mattnappo committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    b6fa509 View commit details
    Browse the repository at this point in the history

  8. Try to fix tests

    @mattnappo
    mattnappo committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    6071891 View commit details
    Browse the repository at this point in the history

  9. Retry

    @mattnappo
    mattnappo committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    70c49ff View commit details
    Browse the repository at this point in the history

  10. Undo warning

    @mattnappo
    mattnappo committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    5b423f5 View commit details
    Browse the repository at this point in the history

  11. Await

    @mattnappo
    mattnappo committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    817709f View commit details
    Browse the repository at this point in the history

  12. Try using async client

    @mattnappo
    mattnappo committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    3259b2b View commit details
    Browse the repository at this point in the history

  13. Use servicer

    @mattnappo
    mattnappo committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    3c3209e View commit details
    Browse the repository at this point in the history

  14. Use servicer

    @mattnappo
    mattnappo committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    a9070ff View commit details
    Browse the repository at this point in the history

  15. Lint

    @mattnappo
    mattnappo committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    153eb0a View commit details
    Browse the repository at this point in the history

  16. Add sleep in test

    @mattnappo
    mattnappo committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    5bb4044 View commit details
    Browse the repository at this point in the history

  17. Reduce sleep time

    @mattnappo
    mattnappo committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    91b5665 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Merge branch 'main' into matt/gvisor-flake-fix

    @thundergolfer
    thundergolfer committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7e7d692 View commit details
    Browse the repository at this point in the history

  2. Address review

    @mattnappo
    mattnappo committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    74ae84a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'matt/gvisor-flake-fix' of github.com:modal-labs/modal-c… 

    …lient into matt/gvisor-flake-fix
    @mattnappo
    mattnappo committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7bbae23 View commit details
    Browse the repository at this point in the history

  4. Run entire restore phase within the lock

    @mattnappo
    mattnappo committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    c0f5fcb View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into matt/gvisor-flake-fix

    @thundergolfer
    thundergolfer committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    87a9036 View commit details
    Browse the repository at this point in the history