Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small type improvements #2055

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Small type improvements #2055

merged 1 commit into from
Aug 1, 2024

Conversation

mwaskom
Copy link
Contributor

@mwaskom mwaskom commented Jul 29, 2024

A few opportunistic fixes to Pyright warnings in the client. Lots more to fix; this is just some low-hanging fruit (making client.stub resolve properly yields some nice IDE QOL improvements though!)

@mwaskom
Copy link
Contributor Author

mwaskom commented Aug 1, 2024

@prbot approve

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @erikbern will follow-up review this.

@mwaskom mwaskom merged commit ddee9b4 into main Aug 1, 2024
22 checks passed
@mwaskom mwaskom deleted the michael/type-fixes branch August 1, 2024 20:51
@erikbern
Copy link
Contributor

erikbern commented Aug 1, 2024

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants