Remove all output mgmt from the resolver #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikbern
force-pushed
the
erikbern/resolver-no-output
branch
from
aa7504d
to
393a4f7
Compare
erikbern
force-pushed
the
erikbern/resolver-no-output
branch
from
d03897d
to
5d5e301
Compare
erikbern
changed the title
mwaskom
approved these changes
Jul 31, 2024
|
danke @mwaskom |
erikbern
added a commit
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of storing a Rich
Treeon the resolver, create it on the output manager.For convenience reasons it's useful to construct an insivisble tree if output isn't enabled. That way everywhere we add status rows, we don't have to check if output is enabled. However this means we need to use a class variable since the singleton may not exist.
We might want to change this in the future if we don't want Rich to be a dependency. It's not, hard just need to add a bunch of
ifstatements.