Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process Batched inputs and outputs on client side #2064

Merged
merged 25 commits into from
Aug 8, 2024
Merged

Process Batched inputs and outputs on client side #2064

merged 25 commits into from
Aug 8, 2024

Conversation

cathyzbn
Copy link
Contributor

Describe your changes

Support multiple processing multiple inputs and serializing multiple outputs when function is batched.

@cathyzbn cathyzbn marked this pull request as ready for review July 31, 2024 20:48
@cathyzbn cathyzbn requested a review from gongy July 31, 2024 20:48
@cathyzbn cathyzbn requested a review from gongy August 5, 2024 14:12
@cathyzbn cathyzbn requested a review from gongy August 7, 2024 14:03
gongy
gongy reviewed Aug 8, 2024
View reviewed changes
Copy link
Contributor

@gongy gongy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah we are so close! I think we can take this PR to remove a bunch of existing tech debt in output logic

modal/_container_io_manager.py Show resolved Hide resolved
modal/_container_io_manager.py Outdated Show resolved Hide resolved
gongy
gongy approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@gongy gongy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

send it!! 🚢

@cathyzbn cathyzbn merged commit fbe6b5b into main Aug 8, 2024
22 checks passed
@cathyzbn cathyzbn deleted the cathy/batch_input_output branch August 8, 2024 18:57
mwaskom added a commit that referenced this pull request Aug 8, 2024
@mwaskom
Revert "Process Batched inputs and outputs on client side (#2064)"
a7018ba 
This reverts commit fbe6b5b.
mwaskom added a commit that referenced this pull request Aug 8, 2024
@mwaskom
Revert "Process Batched inputs and outputs on client side (#2064)" (#…
14beb11 
…2080)

This reverts commit fbe6b5b.
@cathyzbn cathyzbn restored the cathy/batch_input_output branch August 8, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gongy gongy gongy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cathyzbn @gongy