Re-release of atomic deployments through AppPublish #2066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All internal unit and integration tests pass against this branch: https://github.com/modal-labs/modal/pull/14534 |
mwaskom
force-pushed
the
michael/app-publish-again
branch
from
ba3f530
to
dffaffb
Compare
|
Only new line of code here compared to the previous release is https://github.com/modal-labs/modal-client/pull/2066/files#diff-87e1f4fd05c5e1972a1b8d781a518822704dd8fba567111f9b74ad8a3c9959fdR354 |
|
@prbot approve |
![modal-pr-review-automation[bot]](https://avatars.githubusercontent.com/in/335990?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the reversion of #2043, using the new explicit
defer_updatesflag in theFunctionCreateRequest.[DO BEFORE MERGE] I am hardcoding the v0.64.1 version so I can try to run integration tests against it. Should roll that back to v0.64.0 manually before merging so that we don't accidentally skip a version. (Not the worst thing in the world, but would be a little confusing).