Reword log message when function raises a cancellation error #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![modal-pr-review-automation[bot]](https://avatars.githubusercontent.com/in/335990?s=60&v=4){kind=small}
mwaskom
force-pushed
the
michael/improve-cancellation-error
branch
from
6dbc5ae
to
ebb04e6
Compare
mwaskom
force-pushed
the
michael/improve-cancellation-error
branch
from
ebb04e6
to
3bbbb4b
Compare
erikbern
previously requested changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous log message was a bit misleading as we can get to this line for reasons other than the user explicitly cancelling a function call — for example if the function that spawned the function call hits its retry limit, or potentially anything else that causes an
asyncio.CancelledErrorto bubble up.Related to MOD-3132. Not sure if it closes it — we may be able to do more here — but wanted to do a quick fix to make the message less actively confusing.