Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOD-3431] Add default value field to ClassParameterSpec #2072

Merged
merged 8 commits into from
Aug 5, 2024
Merged

[MOD-3431] Add default value field to ClassParameterSpec #2072

merged 8 commits into from
Aug 5, 2024

Conversation

devennavani
Copy link
Contributor

@devennavani devennavani commented Aug 5, 2024 •
edited
Loading

[MOD-3431]

Add has_default field to ClassParameterSpec to indicate whether arg of __init__ was given default value.

Also include oneof field to store the default value. If ParameterType is ParameterType.PARAM_TYPE_STRING then the string_default field should be present, else if ParameterType is ParemeterType.PARAM_TYPE_INT then the int_default field should be present.

modal-pr-review-automation[bot]
modal-pr-review-automation bot approved these changes Aug 5, 2024
View reviewed changes
Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved 👍. This diff qualified for automatic approval and doesn't need follow up review.

@devennavani devennavani changed the title Add default value field to ClassParameterSpec [MOD-3431] Add default value field to ClassParameterSpec Aug 5, 2024
@devennavani devennavani marked this pull request as ready for review August 5, 2024 16:07
@devennavani devennavani requested review from mwaskom and freider and removed request for freider August 5, 2024 16:09
@devennavani devennavani merged commit 782f90f into main Aug 5, 2024
23 checks passed
@devennavani devennavani deleted the deven/add_default_to_class_parameter_spec branch August 5, 2024 16:17
freider
freider reviewed Aug 6, 2024
View reviewed changes
Copy link
Contributor

@freider freider left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freider freider freider left review comments

@modal-pr-review-automation Modal PR Review Automation modal-pr-review-automation approved these changes

@mwaskom mwaskom Awaiting requested review from mwaskom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devennavani @freider