Support dynamic max_concurrency in client concurrency logic #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathyzbn
force-pushed
the
cathy/flexible-ci-inputs
branch
from
38b4ac5
to
8b74df9
Compare
gongy
reviewed
Aug 28, 2024
modal/_container_io_manager.py
Outdated
| @@ -177,6 +179,111 @@ def validate_output_data(self, data: Any) -> List[Any]: | |||
| return data | |||
|
|
|||
|
|
|||
| class ConcurrencyManager(asyncio.Semaphore): | |||
There was a problem hiding this comment.
Just noting we're planning on moving this complexity out of the client soon.
gongy
reviewed
Aug 28, 2024
gongy
reviewed
Aug 29, 2024
gongy
reviewed
Aug 29, 2024
gongy
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Refactored concurrency semaphore to a dynamic semaphore in Concurrency Manager. When max_concurrency specified, client will send RPC request to get the desired concurrency from server and change its concurrency.
Check these boxes or delete any item (or this section) if not relevant for this PR.
Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.