Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrent Logging Interface #2167

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Concurrent Logging Interface #2167

wants to merge 4 commits into from

Conversation

cathyzbn
Copy link
Contributor

@cathyzbn cathyzbn commented Aug 29, 2024

Describe your changes

Add modal.experimental.logger for printing and logging.


Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.


Changelog

Added modal.experimental.logger to correctly tag logs for concurrent inputs execution to their respective input ids.

@cathyzbn cathyzbn marked this pull request as ready for review August 29, 2024 20:27
@cathyzbn cathyzbn requested a review from gongy August 29, 2024 20:39
@cathyzbn cathyzbn changed the title Concurrent Logging Concurrent Logging Interface Aug 30, 2024
@mwaskom
Copy link
Contributor

mwaskom commented Sep 3, 2024

Will users expect this to act like Python's builtin logger? i.e. that you would call it as modal.logger.info(...), modal.logger.debug(...), etc.?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants