Use timeout in the SandboxGetTunnels request #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit swaps out the `poll` variable for a `timeout` variable which can be used to control the length of blocking for the SandboxGetTunnels RPC.
|
@prbot approve |
![modal-pr-review-automation[bot]](https://avatars.githubusercontent.com/in/335990?s=60&v=4){kind=small}
thundergolfer
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This commit swaps out the
pollvariable for atimeoutvariable which can be used to control the length of blocking for the SandboxGetTunnels RPC.Backward/forward compatibility checks
Check these boxes or delete any item (or this section) if not relevant for this PR.
[ ] Client+Server: this change is compatible with old servers[ ] Client forward compatibility: this change ensures client can accept data intended for later versions of itselfThis change is not backwards compatible, but this is fine as nothing is using this data.
Changelog