Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to rustc's archive builder #2459

Merged
merged 2 commits into from
May 23, 2023

Conversation

zhassan-aws
Copy link
Contributor

Description of changes:

Replace our own archive module and ArchiveBuilder with rustc's ArArchiveBuilder that was introduced in rust-lang/rust#97485.

Resolved issues:

Resolves #1957

Related RFC:

Optional #ISSUE-NUMBER.

Call-outs:

Testing:

  • How is this change tested? Current regressions

  • Is this a refactor change? Mostly a cleanup

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@zhassan-aws zhassan-aws requested a review from a team as a code owner May 23, 2023 16:51
Copy link
Contributor

@jaisnan jaisnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@zhassan-aws zhassan-aws enabled auto-merge (squash) May 23, 2023 19:38
@zhassan-aws zhassan-aws merged commit 6064b33 into model-checking:main May 23, 2023
@zhassan-aws zhassan-aws deleted the archive-cleanup branch May 23, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate changes to archive.rs
3 participants